New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update and rearrange munin configuration file and docs #65
Conversation
maxulysse
commented
Aug 7, 2019
- Improve description
- Add maxForks=48 in process
- Update max_memory to 754.GB
- Update max_cpus to 48
- Fix path to iGenomes
I closed #52, because, I totally forgot it was there, so I deleted my fork before I noticed I wanted to do some changes on this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems what I can see.
docs/munin.md
Outdated
To use, run the pipeline with `-profile munin`. This will download and launch the [`munin.config`](../conf/munin.config) which has been pre-configured with a setup suitable for the MUNIN cluster. Using this profile, a docker image containing all of the required software will be downloaded, and converted to a Singularity image before execution of the pipeline. | ||
To use, run the pipeline with `-profile munin`. | ||
This will download and launch the [`munin.config`](../conf/munin.config) which has been pre-configured with a setup suitable for the MUNIN cluster. | ||
Using this profile, a docker image containing all of the required software will be downloaded, and converted to a Singularity image before execution of the pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run with either docker
or singularity
with this profile? May need to be clarified here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can, but good point, I'll clarify that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some clarification
Co-Authored-By: Harshil Patel <drpatelh@users.noreply.github.com>
Co-Authored-By: Harshil Patel <drpatelh@users.noreply.github.com>
Wow, are we sure we want to set the max memory that high? Same for CPU, the linux itself needs something to run on :D |
Yes, VEP is very memory hungry... |
I also removed autoMounts which was definitively failing when I tried |
Well at least reserve 2GB and 2 CPU just for the linux. I mean if you force it to much the server will crash or your VEP will throw segfault. |
That does sound sensible :-D |
Ahhh...so nice to see the tests passing again 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just trying out.