Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azurebatch: expose tokenDuration parameter #688

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Azurebatch: expose tokenDuration parameter #688

wants to merge 3 commits into from

Conversation

tanaes
Copy link

@tanaes tanaes commented May 18, 2024

Addresses issue #687

@tanaes tanaes requested a review from adamrtalbot as a code owner May 18, 2024 18:46
mashehu
mashehu reviewed May 19, 2024
View reviewed changes
conf/azurebatch.config Outdated Show resolved Hide resolved
@adamrtalbot @mashehu
Update conf/azurebatch.config
b6b0f8a 
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
adamrtalbot
adamrtalbot approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped the default to the same as Nextflow.

jfy133
jfy133 reviewed May 25, 2024
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I wonder if such extra parameters will result in validation warnings in nf-core pipelines? (Unknown parama type things)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu left review comments

@jfy133 jfy133 jfy133 approved these changes

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanaes @mashehu @adamrtalbot @jfy133