Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

communicate yeast+fly as alternative spike-in genomes #196

Merged
merged 1 commit into from
May 23, 2023
Merged

communicate yeast+fly as alternative spike-in genomes #196

merged 1 commit into from
May 23, 2023

Conversation

smoe
Copy link
Contributor

@smoe smoe commented May 19, 2023

Hello,

This is my very first contribution to nextflow and its many workflows - and it is a small one. It is just a little hurdle that I needed to overcome to help with an analysis with a "CUT&RUN Assay Kit" by Cell Signaling Technology that advises to spike with yeast DNA. I then found everything nicely prepared on your side but had to look into the source tree to find that information and then at the genomes definition to find the right identifiers - I anticipate this patch to help increasing the user base of your workflow - just a tiny bit that is.

I added respective comments/changes to the description in the .json files and usage.md.

PR checklist

  • Make sure your code lints (nf-core lint).

Not done, admittedly, did not find lint on my conda installation.

  • CHANGELOG.md is updated.

Done. I also fixed an omitted hyphen of a related earlier entry ("Spikein" -> "Spike-in", hope that is ok, can happily move that into another commit/PR).

  • README.md is updated (including new tool citations and authors/contributors).

Well, I should not add myself, and maybe not at all for those few comments.

@chris-cheshire
Copy link
Contributor

Hi @smoe thanks for your message and for your contributions - these changes all look sensible to me! They will be in the next release

@github-actions
Copy link

github-actions bot commented May 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0e5901a

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-05-19 14:05:07

@chris-cheshire chris-cheshire merged commit c749c45 into nf-core:dev May 23, 2023
119 checks passed
@smoe smoe deleted the smoe-PrepareForYeastAsAlternative branch May 24, 2023 10:27
@tamara-hodgetts tamara-hodgetts mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-cheshire chris-cheshire chris-cheshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoe @chris-cheshire