Skip to content

Commit

Permalink
Merge pull request #130 from adamrtalbot/remove_aws_ecr_public_profile
Browse files Browse the repository at this point in the history
Remove_aws_ecr_public_profile
  • Loading branch information
edmundmiller committed Jun 20, 2023
2 parents 26abd17 + 31be148 commit 5965e99
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 36 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/awsfulltest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
{
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/demultiplex/results-${{ github.sha }}"
}
profiles: test_full,public_aws_ecr,aws_tower
profiles: test_full,aws_tower
- uses: actions/upload-artifact@v3
with:
name: Tower debug log file
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/awstest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
{
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/demultiplex/results-test-${{ github.sha }}"
}
profiles: test,public_aws_ecr,aws_tower
profiles: test,aws_tower
- uses: actions/upload-artifact@v3
with:
name: Tower debug log file
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- [#127](https://github.com/nf-core/demultiplex/pull/127) Add `singularity.registry = 'quay.io'` and bump NF version to 23.04.0

## `Removed`

- Remove `public_aws_ecr` profile.

## 1.3.2 - 2023-06-07

### `Fixed`
Expand Down
31 changes: 0 additions & 31 deletions conf/public_aws_ecr.config

This file was deleted.

3 changes: 0 additions & 3 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ profiles {
executor.cpus = 16
executor.memory = 60.GB
}
public_aws_ecr {
includeConfig 'conf/public_aws_ecr.config'
}
test { includeConfig 'conf/test.config' }
test_bases2fastq { includeConfig 'conf/test_bases2fastq.config' }
test_bcl2fastq { includeConfig 'conf/test_bcl2fastq.config' }
Expand Down

0 comments on commit 5965e99

Please sign in to comment.