Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove_aws_ecr_public_profile #130

Merged
merged 6 commits into from Jun 20, 2023
Merged

Remove_aws_ecr_public_profile #130

merged 6 commits into from Jun 20, 2023

Conversation

adamrtalbot
Copy link
Collaborator

Remove public_aws_ecr profile.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 31be148

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • schema_description - No description provided in schema for parameter: skip_tools

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-20 10:39:42

edmundmiller
edmundmiller reviewed Jun 19, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -46,6 +50,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### `Changed`

- [#94](https://github.com/nf-core/demultiplex/issues/94) update documentation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this whitespace addition is intentional. It's on a release that was already cut as well.

edmundmiller
edmundmiller approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the whitespace changelog addition!

adamrtalbot
adamrtalbot commented Jun 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@edmundmiller edmundmiller merged commit 5965e99 into nf-core:dev Jun 20, 2023
6 checks passed
@Aratz Aratz mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamrtalbot @edmundmiller