Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metagenomics module #249

Closed
jfy133 opened this issue Oct 5, 2019 · 7 comments · Fixed by #355
Closed

Add metagenomics module #249

jfy133 opened this issue Oct 5, 2019 · 7 comments · Fixed by #355
Assignees
Labels
enhancement New feature or request feature

Comments

@jfy133
Copy link
Member

jfy133 commented Oct 5, 2019

Is your feature request related to a problem? Please describe.
A standard step of ancient metagenomics work (pathogens, microbiome), is now performing a metagenomic screening i.e. rapid/approximate alignment against a reference database of many genomes at once - typically on the off-target reads of the original host (e.g. host is human, but want to look what bacterial infection killed the person). It would be another good end point of EAGER is a basic OTU table (and some summaries), as initial microbial composition check before downstream analysis outside the scope of EAGER.

This would also be a nice upgrade from EAGER1, for any future publication as it brings EAGER up-to-date with the current state of the aDNA field.

Describe the solution you'd like
Add meta-genomic module.

Suggestions:

  • HOPS Pipeline (currently requires a slight modification to the conda recipe to make malt-extract accessible via a environment variable)
  • Kraken (@maxibor - would need your input here)

Other things to consider
MALT (used in HOPS) often requires a large amount of MEM/CPUs depending on the database. How to specify this/warn the user?

@jfy133 jfy133 added this to the V2.1 "Ulm" milestone Oct 5, 2019
@jfy133 jfy133 self-assigned this Oct 5, 2019
@apeltzer
Copy link
Member

apeltzer commented Oct 6, 2019

All in V2.1? :-D

@jfy133
Copy link
Member Author

jfy133 commented Oct 6, 2019

HOPS certainly. It'll be straight forward once Ron has updated the HOPS recipe.

@jfy133 jfy133 added enhancement New feature or request feature labels Oct 29, 2019
@jfy133
Copy link
Member Author

jfy133 commented Nov 25, 2019

#284

@apeltzer
Copy link
Member

All there in dev, coming with 2.1.0 !

@jfy133 jfy133 reopened this Jan 31, 2020
@jfy133
Copy link
Member Author

jfy133 commented Jan 31, 2020

Re-opening after reconsideration of adding Kraken with @maxibor , which is more accesible tool to wider labs and is pretty commonly used now. Maxime is the expert here so will assign that to him.

@maxibor
Copy link
Member

maxibor commented Feb 19, 2020

Kraken PR with #355

@maxibor maxibor linked a pull request Feb 19, 2020 that will close this issue
8 tasks
@jfy133
Copy link
Member Author

jfy133 commented Feb 21, 2020

Thanks @maxibor !

@jfy133 jfy133 closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants