-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MALT metagenomic classifier functionality #284
Conversation
Updating
…ectories don't work for MALT
…age and added output docs
Can you update the tests as the PR you mentioned has been merged now? That will then perform a final tests upon which I'm reviewing then - thanks a bunch! |
Done! I've only added github actions testing though. Let me know if you also want travis a the same time and I'll work out how to add it (it's a little complicated because I have to first download the MALT databsae, as MALT expects a dir rather than files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some more documentation please!
Oops sorry - I thought MALT was merged already! So I just started using the same branch for the next step. The new commit isn't actually working yet ;). Reflagged as WIP! |
@apeltzer assuming tests go through, this should be ready. Note, to compensate for the lack of documentation in your last comment - I added lots extra for you to check ;). |
…version of nextflow from travis" This reverts commit 9672855.
I'm closing this as Im finding problems and it doesn't make sense to run github actions on my personal account and here. Will make a new one onceit's working! |
This begins adding metagenomic classifier functionality to EAGER primarily for pathogen screeening.
The exact classifer can be specified - but currently only MALT is implemented (as precursor for HOPS).
Path in github actions test for database downloading will be pointed to nf-core once nf-core/test-datasets#97
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md