Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BowTie2 support #257

Closed
jfy133 opened this issue Oct 21, 2019 · 5 comments · Fixed by #476
Closed

Add BowTie2 support #257

jfy133 opened this issue Oct 21, 2019 · 5 comments · Fixed by #476
Labels
enhancement New feature or request feature
Milestone

Comments

@jfy133
Copy link
Member

jfy133 commented Oct 21, 2019

Is your feature request related to a problem? Please describe.
This was previously in EAGER1, but also has benefit of "better for investigating absent gene regions since it can split the reads when mapping." (requested by Ash V. in CPH)

@jfy133 jfy133 added enhancement New feature or request feature labels Oct 29, 2019
@jfy133 jfy133 added this to the V2.2 "Wangen" milestone Nov 25, 2019
@jfy133
Copy link
Member Author

jfy133 commented May 7, 2020

Recommended maping settings for aDNA: https://academic.oup.com/mbe/article/35/5/1120/4844088

Additional for UDG treatment and looking for methylation: https://www.frontiersin.org/articles/10.3389/fevo.2020.00105/full#B4

@apeltzer apeltzer modified the milestones: V2.3 "Wangen", V2.2 "Ulm" May 7, 2020
@jfy133 jfy133 modified the milestones: V2.2 "Ulm", V2.3 "Wangen" May 7, 2020
@jfy133 jfy133 modified the milestones: V2.3 "Wangen", V2.2 "Ulm" Jun 6, 2020
@jfy133
Copy link
Member Author

jfy133 commented Jun 6, 2020

Ok, changed my mind on this one. We should include it in 2.2 because it would be important for eager1 parity and also given the Poullet and Orlando paper, would make it more relevent.

I will try to contact the authors and get their recommendations.

@apeltzer
Copy link
Member

apeltzer commented Jun 6, 2020

Docker building here in the repository could also be added then, if we anyways play around with the dev container adding bowtie2 now too

@apeltzer
Copy link
Member

apeltzer commented Jun 8, 2020

Bowtie2 dependency is added too. Remaining would be to allow for alternative mapper instead of bwa ;-)

@apeltzer
Copy link
Member

apeltzer commented Jun 8, 2020

This study reveals that the Bowtie2 mapping conditions recommended (sensitive option, end-to-end mode) returns with larger numbers of read alignments that increase the number of genomic windows available for inference as well as their sequence coverage, which improves accuracy of the predictions. This has important consequences for the nascent field of ancient epigenomics, which, to the best of our knowledge, based all previous predictions on BWA DNA alignments.

https://www.frontiersin.org/articles/10.3389/fevo.2020.00105/full

So we should enable at least that mode if possible :-)

@jfy133 jfy133 linked a pull request Jun 23, 2020 that will close this issue
7 tasks
@jfy133 jfy133 closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants