-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Bowtie2 to address #476
Conversation
trim5 = "${params.bt2_trim5}" != 0 ? "--trim5 ${params.bt2_trim5}" : "" | ||
trim3 = "${params.bt2_trim3}" != 0 ? "--trim3 ${params.bt2_trim3}" : "" | ||
bt2n = "${params.bt2n}" != 0 ? "-N ${params.bt2n}" : "" | ||
bt2l = "${params.bt2l}" != 0 ? "-L ${params.bt2l}" : "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed this in the docs and doesn't require update because it overrides the default from --bt2_sensitivity
i.e. if you supply a value here it will override the default, otherwise the -N parameter is not supplied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few modifications, mostly updating the default parameters
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
Co-authored-by: Maxime Borry <maxibor@users.noreply.github.com>
Anymore @maxibor ?(heh, rhyming) |
nf-core/eager pull request
Many thanks for contributing to nf-core/eager!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker --paired_end
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: CONTRIBUTING.md