Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve realigned bam file when using gatk for genotyping #444

Closed
aidaanva opened this issue Jun 4, 2020 · 5 comments
Closed

Preserve realigned bam file when using gatk for genotyping #444

aidaanva opened this issue Jun 4, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@aidaanva
Copy link
Contributor

aidaanva commented Jun 4, 2020

For both visual inspection of bam files and upstream analysis, it will be great if the realigned bam file can be kept when running the gatk genotyping.

@jfy133
Copy link
Member

jfy133 commented Jun 4, 2020

To stop cluttering up output, I will make this optional with a flag, so a user can explicitly call it.

@jfy133 jfy133 added this to the V2.2 "Ulm" milestone Jun 8, 2020
@jfy133
Copy link
Member

jfy133 commented Jun 8, 2020

Same context - add check that a JAR is actually supplied (ending in jar)

@jfy133 jfy133 added the enhancement New feature or request label Jun 8, 2020
@jfy133 jfy133 closed this as completed Jun 9, 2020
@aidaanva
Copy link
Contributor Author

aidaanva commented Jul 8, 2020

Thank you for adding the flag. I have an extra request, would it be possible that when the flag is specified the bam file gets also indexed? We usually use the realigned bam files for visual inspection in IGV and that would be useful.

@apeltzer
Copy link
Member

apeltzer commented Jul 8, 2020

Hi @aidaanva ! Yes, sure. Should be easy to have something like this:

def run_indexing = params.saveIntermediates ? 'samtoolx index bamfile' : ''
script
"""
...
$run_indexing
"""

(and have an optional output statement in the output: section of that particular step 👍

@jfy133 jfy133 reopened this Jul 8, 2020
@apeltzer
Copy link
Member

apeltzer commented Jul 8, 2020

Should be fixed in #495

@jfy133 jfy133 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants