Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref genomes & other behaviour #194

Merged
merged 19 commits into from Apr 12, 2019
Merged

Conversation

apeltzer
Copy link
Member

Trying to fix couple of stuff , e.g. fasta reference naming, indexing availability without channels so we can re-use them efficiently.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@apeltzer apeltzer added the WIP Work in progress label Apr 10, 2019
@apeltzer apeltzer requested a review from maxibor April 10, 2019 13:42
@apeltzer apeltzer changed the base branch from master to dev April 10, 2019 13:43
@maxibor
Copy link
Member

maxibor commented Apr 10, 2019

Looks good to me for merging if Travis says bueno

@apeltzer
Copy link
Member Author

Yeah, just the indexes missing 👍 I'll also try to go back supporting whatever kind of index is provided by users.... Fa, Fasta, fn, all good for me :....

@apeltzer
Copy link
Member Author

This now uses value channels for input fasta files, that are not consumed. Additionally, I cleaned up the code quite a bunch 👍

@apeltzer apeltzer removed the WIP Work in progress label Apr 11, 2019
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous approve was a mistake - but mobile github site doesn't give me an option to revoke... I'll test your personal branch tonight

@apeltzer
Copy link
Member Author

One missing thing is gz input for fasta but I am almost there - maybe after dinner or tomorrow. Everything else should work

@phue
Copy link
Member

phue commented Apr 11, 2019

Wasn't there some problem with using the file method because input files lying on different filesystems were not staged properly? I remember something along these lines which made us switch to channels for everything.

@apeltzer
Copy link
Member Author

It was, but I talked to Paolo and apparently that is not true and was probably a misconfiguration on our side with Singularity missing required bind paths - so one can assume this approach works fine.

@apeltzer apeltzer merged commit 0b4fe32 into nf-core:dev Apr 12, 2019
@apeltzer apeltzer deleted the fix-ref-genomes branch April 12, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants