New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ref genomes & other behaviour #194
Conversation
Looks good to me for merging if Travis says bueno |
Yeah, just the indexes missing 👍 I'll also try to go back supporting whatever kind of index is provided by users.... Fa, Fasta, fn, all good for me :.... |
This now uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous approve was a mistake - but mobile github site doesn't give me an option to revoke... I'll test your personal branch tonight
One missing thing is gz input for fasta but I am almost there - maybe after dinner or tomorrow. Everything else should work |
Wasn't there some problem with using the |
It was, but I talked to Paolo and apparently that is not true and was probably a misconfiguration on our side with Singularity missing required |
Trying to fix couple of stuff , e.g. fasta reference naming, indexing availability without channels so we can re-use them efficiently.
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md