[Merge #342 first] Performance improvement: zcat to cat #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get latest Nfcore tools update
|
Guess you might have to update your branch PR first then we can merge this in 馃憤 |
|
Yup. If you could approve and merge the nftools linting sync that would help! Edit: you already did. Sorry! Still getting hang out the GitHub Android app xD |
Get latest changes from dev!
|
@apeltzer Now synced! Review when ready! |
apeltzer
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replaces zcat with cat. Removes need to uncompress FASTQs to recompress them, because gzip is too clever for that. Therefore we get small performance boost 馃殌
Addresses #339
PR checklist
nextflow run . -profile test,docker).nf-core lint .).Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md