Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add when conditions to prepare #58

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Add when conditions to prepare #58

wants to merge 5 commits into from

Conversation

SPPearce
Copy link
Contributor

@SPPearce SPPearce commented Jun 5, 2024

As noted in #56 , the BWA index generation happens every time (and doesn't seem to cache, which makes it even more annoying).
This PR adds when conditions to the prepare genome steps so they don't run if the appropriate parameters are passed.

Copy link

github-actions bot commented Jun 5, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 916a1bf

+| ✅ 169 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-05 14:57:22

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me when you're ready for review. Perhaps I can look into why it doesn't cache, so please keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants