Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-cloud CI for full-sized tests #150

Merged
merged 3 commits into from
May 8, 2023
Merged

Add multi-cloud CI for full-sized tests #150

merged 3 commits into from
May 8, 2023

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented May 6, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented May 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7d858a3

+| ✅ 150 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-06 19:37:56

robsyme
robsyme approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have the release version in the run_name, but that would just be icing on the cake, really.

Everything else looks good.

.github/workflows/cloud_tests_full.yml
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_CE_AWS_CPU }}
workdir: "${{ secrets.TOWER_BUCKET_AWS }}/work/fetchngs/work-${{ github.sha }}"
run_name: "aws_fetchngs_full"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is possible to add the release version to this run_name parameter?

robsyme
robsyme approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have the release version in the run_name, but that would just be icing on the cake, really.

Everything else looks good.

@drpatelh
Copy link
Member Author

drpatelh commented May 8, 2023

We tried that when we were testing right and couldn't find an easy solution. Maybe we can add that as a follow up. We still need to add these Actions to the pipeline template so they become part of the syncing process to all pipelines.

@drpatelh drpatelh merged commit e90a023 into nf-core:dev May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robsyme robsyme robsyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drpatelh @robsyme