Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup: remove commented out CI #258

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fixup: remove commented out CI #258

merged 2 commits into from
Jan 29, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Jan 29, 2024 •
edited
Loading

I forgot to add the CHANGELOG and left some commented code in the CI. Sorry.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot adamrtalbot changed the base branch from master to dev January 29, 2024 17:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit a78310f

+| ✅ 139 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   6 tests had warnings |!
-| ❌   7 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - assets/sendmail_template.txt does not match the template
  • files_unchanged - assets/nf-core-fetchngs_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-fetchngs_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-fetchngs_logo_dark.png does not match the template

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • files_unchanged - File does not exist: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.12
  • Run at 2024-01-29 17:23:17

@adamrtalbot adamrtalbot changed the title fixup remove commented out ci fixup remove commented out CI Jan 29, 2024
@adamrtalbot adamrtalbot changed the title fixup remove commented out CI fixup: remove commented out CI Jan 29, 2024
@nf-core nf-core deleted a comment from github-actions bot Jan 29, 2024
@drpatelh drpatelh merged commit a5c1ae2 into dev Jan 29, 2024
40 of 41 checks passed
@adamrtalbot adamrtalbot deleted the fixup_remove_commented_out_ci branch January 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamrtalbot @drpatelh