Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert sratools fasterqdump version #261

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Revert sratools fasterqdump version #261

merged 4 commits into from
Jan 31, 2024

Conversation

drpatelh
Copy link
Member

Partial fix for #221

Reverting the version for sratools/fasterqdump from 3.0.8 -> 2.11.0 because a number of users have reported having issues when they have a . (dot) anywhere in their path. We can update this version when the fix has been pushed upstream (see ncbi/sra-tools#865)

In the meantime, anyone wanting to use more recent support for ngc files can use v3.0.8 via a custom config file passed to the pipeline:

process {
    withName: 'SRATOOLS_FASTERQDUMP' {
        container = 'quay.io/biocontainers/mulled-v2-5f89fe0cd045cb1d615630b9261a1d17943a9b6a:2f4a4c900edd6801ff0068c2b3048b4459d119eb-0'
    }
}

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited

nf-core lint overall result: Failed ❌

Posted for pipeline commit f932649

+| ✅ 147 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   6 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

  • files_unchanged - assets/sendmail_template.txt does not match the template

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_unchanged - File does not exist: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.12
  • Run at 2024-01-31 12:19:58

@drpatelh drpatelh mentioned this pull request Jan 30, 2024
Open
adamrtalbot
adamrtalbot approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out, damned spot!

@drpatelh drpatelh merged commit 7f0a645 into nf-core:dev Jan 31, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drpatelh @adamrtalbot