Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Action to run full-sized test for all 3 download methods #288

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Feb 22, 2024

Be nice to do simple benchmarking on all public clouds across the different download methods we have available in the pipeline i.e.

  • --download_method ftp (default)
  • --download_method aspera
  • --download_method sratools

Copy link

github-actions bot commented Feb 22, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2263d70

+| ✅ 154 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 1.12.0

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-22 14:19:28

@adamrtalbot
Copy link
Contributor

adamrtalbot commented Feb 22, 2024

The code seems to show downloading for all 3 cloud providers but description is using different methods?

nevermind, I see it now.

@drpatelh drpatelh merged commit dc7c39d into nf-core:dev Feb 22, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants