Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taxprofiler support for --nf_core_pipeline #97

Merged
merged 4 commits into from Jun 30, 2022
Merged

Add taxprofiler support for --nf_core_pipeline #97

merged 4 commits into from Jun 30, 2022

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 11, 2022 •
edited

PR checklist

Closes #96

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 11, 2022 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 920c62f

+| ✅ 144 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-11 19:14:45

This was referenced Jun 11, 2022
Closed
Closed
drpatelh
drpatelh reviewed Jun 11, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jfy133 ! 🚀

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
@jfy133 @drpatelh
Apply suggestions from code review
4bd5ccd 
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@jfy133 jfy133 requested a review from drpatelh June 11, 2022 19:10
@drpatelh drpatelh merged commit 9fbfd67 into nf-core:dev Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

@Midnighter Midnighter Awaiting requested review from Midnighter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfy133 @drpatelh