Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combgc new input param #262

Merged
merged 3 commits into from Apr 21, 2023
Merged

Combgc new input param #262

merged 3 commits into from Apr 21, 2023

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented Apr 21, 2023 •
edited

Closes #256
Is the same thing like yesterday (#258)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e381fbe

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-21 09:51:45

@jasmezz jasmezz requested a review from louperelo April 21, 2023 10:20
louperelo
louperelo approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@louperelo louperelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add the contribution to the Changelog

@jasmezz jasmezz merged commit a0021ee into dev Apr 21, 2023
@jasmezz jasmezz deleted the combgc_new_input_param branch April 21, 2023 10:43
@jasmezz jasmezz mentioned this pull request Apr 26, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louperelo louperelo louperelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasmezz @louperelo