New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version 1.3.0 #101
New version 1.3.0 #101
Conversation
nf-core template merge v1.11
Update issue templates
Important! Template update for nf-core/tools v1.12
[MODIF] update input parameters
Dockerfile
Outdated
# Instruct R processes to use these empty files instead of clashing with a local version | ||
RUN touch .Rprofile | ||
RUN touch .Renviron | ||
RUN touch .Renviron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is not in the TEMPLATE
anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep it so far, to avoid any issue with R local library. Is it ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
If you fix the typo, you'll need to add the corresponding files to .nf-core-lint.yml
:
cf https://github.com/nf-core/eager/blob/master/.nf-core-lint.yml
Co-authored-by: Maxime U. Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U. Garcia <max.u.garcia@gmail.com>
Hi @maxulysse . Thanks for the review ! |
ah yes. got it. I'll add the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some smaller things you need to fix/look at, before I'll give the final 👍
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Add patern for all comma separated string options
Hi @mashehu, |
|
Release new nf-core-hic version