Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pipeline to DSL2 #140

Merged
merged 52 commits into from Oct 10, 2022
Merged

Port pipeline to DSL2 #140

merged 52 commits into from Oct 10, 2022

Conversation

christopher-mohr
Copy link
Collaborator

This

  • ports the hlatyping pipeline to DSL2
  • uses existing nf-core modules
  • merges nf-core template updates until 2.6
  • switches to samplesheet input
  • adds functionality for using fastq and bam files in the same run.

We still need a better solution for handling the HLA reference. Currently it is only possible to either process dna or rna data at the same time due to the HLA reference that has to be provided. My suggestion would be to choose the .fasta automatically based on the specified seq_type in the sample sheet AND allow users to specify custom .fasta files in the sample sheet (this might need then an additional process because of the alleles.h5 file).

In order to allow the use of different HLA references in the same run we also need to update the yara_index module and at least add the meta map to the process I guess. @apeltzer what do you think?

PR checklist

@apeltzer
Copy link
Member

apeltzer commented Oct 5, 2022

Nice :)
Yes, please work on an updated yara module - we've worked on that one when modules were started so some stuff wasn't fully clear back then on how to work with it. So an update of the module would be necessary I fear.

Once you updated the module, I can review this here in detail

@apeltzer
Copy link
Member

apeltzer commented Oct 5, 2022

Please ping me on the yara module then @christopher-mohr

@christopher-mohr
Copy link
Collaborator Author

I updated the yara modules to the latest version and removed the FASTA parameter. The HLA references are now automatically set based on the given sequencing type. Not sure if there is an easier/ more elegant way for making sure that the reads are matched with the right index.

In addition I would add the possibility to provide a custom FASTA (for a specific sample) in the sample sheet in a separate PR.

CHANGELOG.md Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to have this on DSL2 now. Some minor comments. I will also run once this is on dev to see if docs are matching expectations 👍🏻

christopher-mohr and others added 6 commits October 10, 2022 16:19
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants