Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master 2.4.0 #321

Merged
merged 73 commits into from
Jun 12, 2023
Merged

Dev -> Master 2.4.0 #321

merged 73 commits into from
Jun 12, 2023

Conversation

sateeshperi
Copy link
Contributor

@sateeshperi sateeshperi commented Jun 2, 2023

Pipeline Updates

  • Updated template to nf-core/tools v2.8
  • Add --bamqc_regions_file parameter for targeted methylation sequencing data Regions file parameter for Qualimap Bamqc #302
  • ✨ Add NF-TEST pipeline end-to-end tests for existing CI tests bump-nf-tests-snapshots-2.8.0 #310
  • NF-TEST pipeline Assertions - ✨ Featuring NF-TEST Snapshots, new File().exists() and !new File().exists() checks
  • 🛠️ tests/pipeline/UTILS.groovy for local groovy functions used in tests

Bug fixes & refactoring

ewels and others added 30 commits December 17, 2022 01:41
remove unused output folder
To match the template
Important! Template update for nf-core/tools v2.8
Co-authored-by: Edmund Miller <edmund.a.miller@protonmail.com>
@sateeshperi sateeshperi added this to the 2.4 milestone Jun 2, 2023
@sateeshperi sateeshperi self-assigned this Jun 2, 2023
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that ignore is a suitable name for a parameter, I think it should be ignore_r1. Similarly with ignore_3prime to make it match up.
Generally ok other than that, a few minor points. There are some #TODO strings, I don't know if that is because they are in the template or where they have come from.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@sateeshperi sateeshperi requested a review from SPPearce June 9, 2023 18:09
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the genome question, otherwise should be good to go.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only thing is copilot may have eaten the <int> calls.

nextflow_schema.json Outdated Show resolved Hide resolved
@sateeshperi sateeshperi merged commit 81f989c into master Jun 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants