Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master 2.5.0 #347

Merged
merged 49 commits into from
Oct 18, 2023
Merged

Dev -> Master 2.5.0 #347

merged 49 commits into from
Oct 18, 2023

Conversation

edmundmiller
Copy link
Collaborator

No description provided.

sateeshperi and others added 30 commits June 12, 2023 14:33
Adding publish mode for coverage2cytosine NOMe-seq filtered GpC coverage files.
Added comment for coverage2cytosine publishing of files.
Some other module updates are available, but those will require changes to the pipeline code.
Important! Template update for nf-core/tools v2.9
Apply easy module updates
Updated zymo preset "--clip_r2" argument value from 15 to 10.
Updated all em_seq preset argument values from 8 to 10.
Wrong display values for "zymo" and "em_seq" presets on help page
support pipeline-specific configs
Support pipeline-specific configs
Important! Template update for nf-core/tools v2.10
@edmundmiller edmundmiller added this to the 2.5.0 milestone Oct 18, 2023
@edmundmiller edmundmiller self-assigned this Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e02fd8c

+| ✅ 153 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-18 10:03:07

@edmundmiller edmundmiller marked this pull request as draft October 18, 2023 08:35
@edmundmiller edmundmiller requested review from a team and FelixKrueger October 18, 2023 08:54
sateeshperi and others added 4 commits October 18, 2023 09:10
I refuse to update this every release.

Co-authored-by: sateeshperi <sateeshperi@users.noreply.github.com>
@edmundmiller edmundmiller marked this pull request as ready for review October 18, 2023 09:45
Copy link
Contributor

@FelixKrueger FelixKrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTS. Very nice work!

Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTF&S

let's go

@edmundmiller edmundmiller merged commit 053e59e into master Oct 18, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants