Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module for pbptyper #2005

Merged
merged 5 commits into from
Sep 7, 2022
Merged

add module for pbptyper #2005

merged 5 commits into from
Sep 7, 2022

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Sep 2, 2022

PR checklist

Closes #2004

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added the new module Adding a new module label Sep 2, 2022
@rpetit3 rpetit3 self-assigned this Sep 2, 2022
@rpetit3
Copy link
Contributor Author

rpetit3 commented Sep 2, 2022

The singularity container isn't available yet, will keep an eye on it and retry in a few days

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing optional input parameter of --db but otherwise LGTM!

@rpetit3
Copy link
Contributor Author

rpetit3 commented Sep 7, 2022

Thank you!

@rpetit3 rpetit3 merged commit a5976c5 into nf-core:master Sep 7, 2022
@rpetit3 rpetit3 deleted the rp3-add-pbptyper branch September 7, 2022 21:29
matthdsm pushed a commit to matthdsm/nf-core-modules that referenced this pull request Sep 28, 2022
* add module for pbptyper

* add optional database parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: pbptyper
2 participants