-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add starting deseq2 differential module #2167
Add starting deseq2 differential module #2167
Conversation
@nf-core-bot fix-linting |
@nf-core-bot fix linting |
Did you use the |
I'll get there- just a WIP for visibility and discussion, I'll get things tested before requesting formal review. |
Maybe change this to a draft PR then :) |
@nf-core-bot fix linting |
@nf-core-bot fix linting |
This reverts commit 0a3ce7a.
(note: singularity failure is just because we're waiting for a build to propagate from biocontainers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! As mentioned in slack there are some features missing that we would like to include but it's good to start with a minimal POC!
One thing that could be done to also test the blocking variables and that the execution with multiple contrasts works fine would be to add another contrast in the example data with a blocking variable provided.
fix typo Co-authored-by: WackerO <43847497+WackerO@users.noreply.github.com>
Thanks @ggabernet! I'm just going to switch the inputs to be keyed by the meta- as per feedback in #2321, will do that quickly now. |
@ggabernet Good point- modifications to the test data here: nf-core/test-datasets#670 |
Actually this would be important only in the case that the files are initially provided to the pipeline with a samplesheet (e.g. multiple fastq files to analyze, each of them with individual sample metadata that is passed to the In the case of the other module that you mentioned #2321 that operates on reference data (e.g. reference |
Thanks @ggabernet (and apologies I just saw this). I was confused in the other review - it seemed like the meta thing was pretty non-negotiable (though as it turned out I think there was a use for it there). In the latest commits I've put the inputs in a single tuple with the 'contrast meta' as the 'meta' rather than a separate channel for the contrast meta, which I think is nicer, but happy to reverse that if you like. (and the additional contrast with blocking factor is now tested too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sure, looks good to me like this too!
Thanks for the review @ggabernet ! |
This PR adds a wrapper for DESeq2. Notes:
bin
directory (see https://nfcore.slack.com/archives/CJRH30T6V/p1665066826554919)bin
, because we don't need an additional library to provide a CLI! So here we can just use the biocontainer for DESeq2 and nothing else, no need to create bespoke containers etc.task.ext.args
route, and are handled within the template.PR checklist
Tackling #2155
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware