Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory unit in germlinecnvcaller modules #5686

Merged
merged 12 commits into from
May 28, 2024

Conversation

ramprasadn
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@ramprasadn ramprasadn requested a review from maxulysse May 23, 2024 19:12
@ramprasadn ramprasadn marked this pull request as ready for review May 23, 2024 19:12
@ramprasadn ramprasadn requested a review from a team as a code owner May 23, 2024 19:23
@ramprasadn ramprasadn marked this pull request as draft May 23, 2024 19:28
@ramprasadn
Copy link
Contributor Author

ramprasadn commented May 23, 2024

Not sure why the two CI tests failed, because they work just fine on my laptop. I am considering if this could be related to disk space problems, so I have included a disk cleanup step to investigate further. Let's see....

@ramprasadn
Copy link
Contributor Author

Okay.. I am starting to think that these failures have nothing to do with my change, as even the current version doesn't seem to work on github CI anymore.

@ramprasadn ramprasadn marked this pull request as ready for review May 24, 2024 09:05
@ramprasadn
Copy link
Contributor Author

@maxulysse what do you think about this one?

@ramprasadn ramprasadn enabled auto-merge May 28, 2024 06:43
@ramprasadn ramprasadn disabled auto-merge May 28, 2024 07:47
@maxulysse
Copy link
Member

by passing the failing tests

@maxulysse maxulysse merged commit cf607b7 into nf-core:master May 28, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants