Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Singularity image path #76

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Remove Singularity image path #76

merged 2 commits into from
Nov 12, 2020

Conversation

drpatelh
Copy link
Member

Given that pulling Singularity images directly isn't supported via https by Nextflow yet (see here) it makes sense to remove these paths from module files until this feature is added. Nextflow would need to recognise that the containers need to be downloaded and add them to a cache as is the normal behaviour for Singularity images converted from Docker.

@grst
Copy link
Member

grst commented Nov 12, 2020

why not just use the http url then?

For me both protocols work:

singularity pull http://depot.galaxyproject.org/singularity/fastqc:0.11.9--0
singularity pull https://depot.galaxyproject.org/singularity/fastqc:0.11.9--0    

@drpatelh
Copy link
Member Author

Yes, but the containers aren't cached properly as they are for example when you pull and convert Docker images. There also seem to be other more sinister things going on possibly at the kernel level as highlighted by @apeltzer in point (1) in this comment.

I think we should wait for this to be tested and implemented properly on the Nextflow side before we start introducing it into workflows otherwise the pipelines will break way more often that anyone has the time to keep up 😅

@grst
Copy link
Member

grst commented Nov 12, 2020

I see... let's merge this then!

@drpatelh
Copy link
Member Author

Thanks @grst !

@drpatelh
Copy link
Member Author

I have also commented out the EClint for now because I don't quite know what to do with it and it may be easier to just deal with that all at once. Also, if we are likely to have traffic coming here after the rnaseq release be good if all of the tests were passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants