Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release prep #103

Merged
merged 13 commits into from Jan 21, 2023
Merged

Release prep #103

merged 13 commits into from Jan 21, 2023

Conversation

edmundmiller
Copy link
Collaborator

No description provided.

@edmundmiller edmundmiller added this to the v2.1.0 milestone Jan 20, 2023
@edmundmiller edmundmiller self-assigned this Jan 20, 2023
@edmundmiller edmundmiller marked this pull request as draft January 20, 2023 16:43
@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8bfc348

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.1.0'
  • pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-21 19:03:04

@edmundmiller edmundmiller marked this pull request as ready for review January 21, 2023 18:14
alyssa-ab
alyssa-ab approved these changes Jan 21, 2023
View reviewed changes
Copy link

@alyssa-ab alyssa-ab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edmundmiller edmundmiller merged commit 219b5cd into dev Jan 21, 2023
@edmundmiller edmundmiller deleted the release-prep branch January 21, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssa-ab alyssa-ab alyssa-ab approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edmundmiller @alyssa-ab