Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging template updates #56

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Merging template updates #56

merged 4 commits into from
Mar 22, 2021

Conversation

subwaystation
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pangenome branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR should take care of #54 and #51.

@subwaystation subwaystation moved this from pangenome to Ready for review in hackathon-march-2021-pipelines Mar 22, 2021
@subwaystation
Copy link
Collaborator Author

The errors from nf-core linting / nf-core (pull-request) are expected, because #49 is not resolved, yet.

Zethson
Zethson approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super quick review. LGTM on short glance

conf/test.config Outdated Show resolved Hide resolved
conf/test_full.config Outdated Show resolved Hide resolved
docs/output.md Show resolved Hide resolved
nextflow.config Show resolved Hide resolved
@subwaystation subwaystation merged commit 7646e5f into nf-core:dev Mar 22, 2021
hackathon-march-2021-pipelines automation moved this from Ready for review to Done Monday Mar 22, 2021
@subwaystation subwaystation mentioned this pull request Mar 22, 2021
Closed
@subwaystation subwaystation self-assigned this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

@ggabernet ggabernet Awaiting requested review from ggabernet

Assignees

@subwaystation subwaystation

Labels
None yet
Projects
No open projects
hackathon-march-2021-pipelines
Done Monday
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@subwaystation @Zethson @nf-core-bot