This repository has been archived by the owner on May 6, 2024. It is now read-only.
Version 1.2 [PLEASE DO NOT MERGE YET] #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and fixed mass calc Experimental/feature/bruker data
* added report info * split decompression step * Included ms1 TIC/BPC * added new data to report channel * added convert_dotd to the schema * fixed bug where passed mass accuracies were bypassed * code formatting
|
So after the changes in #127 mypy is happy and we fixed a bug. |
Mypy found issue fixes
fabianegli
reviewed
Nov 1, 2023
Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
As it is, there is too much logic in this class for it to be a dataclass.
The only_first argument was never used in any function call in the script. It is also very easy to get the whole list of files matching a glob, if necessary.
and make validate_diann_version a method
|
I am still a little bit dismayed by the general lack of tests for the Python scripts, but after #128 is merged, I will approve the PR. |
More fixes for type annotations
fabianegli
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
I really like all the added capabilities of the pipeline and the various improvements! Thank you everyone for your work.
For the future, I think we should find a way to run tests for the Python scripts. Having tests for them would make development on them much faster, safer and enjoyable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).