Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #34

Merged
merged 6 commits into from
May 28, 2024
Merged

Bug fixes #34

merged 6 commits into from
May 28, 2024

Conversation

itrujnara
Copy link
Collaborator

Fixed incorrect hit table merging
Fixed missing columns in score table if nothing was found in a database (important for stat calculation)

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7832ce2

+| ✅ 217 tests passed       |+
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in main.nf.test: Change the test name preferably indicating the test-data and file-format used but keep the " - stub" suffix.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-27 13:41:41

@itrujnara itrujnara marked this pull request as draft May 27, 2024 13:54
@itrujnara itrujnara marked this pull request as ready for review May 27, 2024 14:49
luisas
luisas approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@luisas luisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JoseEspinosa JoseEspinosa merged commit 8b564b5 into nf-core:dev May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisas luisas luisas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itrujnara @luisas @JoseEspinosa