Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(config) use institutional config by default #381

Merged
merged 2 commits into from Aug 25, 2023
Merged

change(config) use institutional config by default #381

merged 2 commits into from Aug 25, 2023

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Aug 21, 2023

Closes: #375

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fevac fevac changed the base branch from master to dev August 21, 2023 14:52
@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @fevac,

It looks like this pull-request is has been made against the nf-core/rnafusion master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/rnafusion dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4c277dd

+| ✅ 156 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-08-21 14:57:06

@fevac fevac marked this pull request as ready for review August 21, 2023 15:00
@fevac fevac requested a review from rannick August 21, 2023 15:01
@rannick
Copy link
Collaborator

rannick commented Aug 25, 2023

@fevac ready to merge!

@fevac fevac merged commit a978a80 into dev Aug 25, 2023
6 checks passed
@fevac fevac mentioned this pull request Aug 25, 2023
Closed
@rannick rannick deleted the default_institutional_config branch November 27, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rannick rannick rannick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use institutional config by default
2 participants
@fevac @rannick