Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megafusion key error fix #382

Merged
merged 3 commits into from Aug 25, 2023
Merged

Conversation

efgstone
Copy link

PR checklist

  • [x ] This comment contains a description of changes (with reason).

@efgstone
Copy link
Author

related to issue: #366

@rannick
Copy link
Collaborator

rannick commented Aug 25, 2023

How have you tested this fix?

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 606d579

+| ✅ 156 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-08-25 10:54:31

@rannick
Copy link
Collaborator

rannick commented Aug 25, 2023

Ah yeah, the cosmic secrets are not known if you are testing on a fork (sigh). @maxulysse @apeltzer do you know a possibility to fix this?

@efgstone
Copy link
Author

Hi @rannick - I have tested the fix and it is working for cases where the KeyError: "['INFO', 'Sample'] not in index" error message was being displayed. It does not solve all issues relating to cases where no fusions are detected though.

@rannick
Copy link
Collaborator

rannick commented Aug 25, 2023

Since we are in the case of a broken dev branch, I will force the merge here, also because CI would not pick an error anyways (stubs only). Let's keep in mind that there will be extra testing once the empty fusions PR is implemented

@rannick rannick merged commit 2023c40 into nf-core:dev Aug 25, 2023
4 of 6 checks passed
@efgstone efgstone deleted the megafusion_key_error_fix branch August 25, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants