Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALMON_TXIMPORT process produces two tsv files that are not marked for export #1188

Closed
robsyme opened this issue Jan 11, 2024 · 4 comments · Fixed by #1302
Closed

SALMON_TXIMPORT process produces two tsv files that are not marked for export #1188

robsyme opened this issue Jan 11, 2024 · 4 comments · Fixed by #1302
Milestone

Comments

@robsyme
Copy link
Contributor

robsyme commented Jan 11, 2024

Description of the bug

The -profile test of nf-core/rnaseq runs the SALMON_TXIMPORT which produces six tsv files which marked for output:

  • salmon.merged.gene_counts.tsv
  • salmon.merged.gene_counts_length_scaled.tsv
  • salmon.merged.gene_counts_scaled.tsv
  • salmon.merged.gene_tpm.tsv
  • salmon.merged.transcript_counts.tsv
  • salmon.merged.transcript_tpm.tsv

... and two tsv files which are not marked for output:

  • salmon.merged.gene_tpm_length_scaled.tsv
  • salmon.merged.gene_tpm_scaled.tsv

I think that these files include valuable data and should be published alongside the others in the outdir.

Command used and terminal output

$ nextflow run -profile test,docker --outdir results

Relevant files

No response

System information

No response

@robsyme robsyme added the bug Something isn't working label Jan 11, 2024
@dross101
Copy link

Another file which would be helpful in the output (STAR-Salmon) would be the *gene_lengths.tsv: effective gene lengths. It is not included in output and would be good base information to have.

@drpatelh drpatelh added this to the 3.15.0 milestone May 13, 2024
@drpatelh drpatelh added enhancement and removed bug Something isn't working labels May 13, 2024
@pinin4fjords
Copy link
Member

@dross101 the effective lengths have been output since 3.12.2

@pinin4fjords
Copy link
Member

Modules has recently moved to nf-core/modules, so addressing this there, will then bump module etc here.

@pinin4fjords
Copy link
Member

Solved in #1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants