Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CODE_OF_CONDUCT and CONTRIBUTING with nf-core template 2.10 #1088

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Update the CODE_OF_CONDUCT and CONTRIBUTING with nf-core template 2.10 #1088

merged 3 commits into from
Oct 11, 2023

Conversation

adamrtalbot
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot adamrtalbot mentioned this pull request Oct 9, 2023
Merged
10 tasks
@adamrtalbot
Copy link
Contributor Author

@nf-core-bot fix linting

@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 468d61a

+| ✅ 144 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-11 19:13:23

@adamrtalbot adamrtalbot mentioned this pull request Oct 10, 2023
Merged
10 tasks
drpatelh
drpatelh reviewed Oct 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
drpatelh
drpatelh approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drpatelh drpatelh merged commit e1d89d8 into dev Oct 11, 2023
7 of 26 checks passed
@drpatelh drpatelh deleted the 2.10_documentation_template_updates branch November 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamrtalbot @drpatelh @nf-core-bot