Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close outstanding issues and amend salmon merge #236

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Close outstanding issues and amend salmon merge #236

merged 2 commits into from
Jun 18, 2019

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jun 18, 2019

Many thanks to contributing to nf-core/rnaseq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

  • Removed genebody_coverage process #195
  • Implemented Pearsons correlation instead of euclidean distance #146
  • Add --stringTieIgnoreGTF parameter #206
  • Resolved link to guidelines is broken #203
  • Removed unnecessary stringtie channels for MultiQC

@drpatelh drpatelh changed the title [WIP] Close outstanding issues and amend salmon merge Close outstanding issues and amend salmon merge Jun 18, 2019
@drpatelh
Copy link
Member Author

Im going to merge this when the tests pass. Hopefully, we can review properly when merging from the salmon to dev.

@drpatelh drpatelh merged commit 5918ddd into nf-core:salmon Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant