Make publishDir mode configurable. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeltzer
requested changes
Mar 3, 2020
There was a problem hiding this comment.
Please also add to CHANGELOG.md - idea is good and has been tested in Sarek already by @maxulysse
|
I guess that one has to be merged in first, then all the linting errors should be gone hopefully 🤞 |
grst
force-pushed
the
feat/config-publish-dir
branch
from
a703abf
to
a44931f
Compare
Salmon used to fail because of an outdated index in the test_gzipped test. Needs to be merged into the nf-core/test-datasets eventually.
grst
force-pushed
the
feat/config-publish-dir
branch
from
d728060
to
33244cc
Compare
|
Merge #394 first! |
apeltzer
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion, feel free to discard...
In our lab, we prefer to use
linkovercopybecause our file system supports it and copying is a waste of time and space.PR checklist
devrather thanmasternextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedLearn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md