Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace featureCounts with Salmon quant #526

Merged
merged 96 commits into from
Dec 11, 2020
Merged

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Dec 9, 2020

Old parameter New parameter
--fc_extra_attributes --gtf_extra_attributes
--fc_group_features --gtf_group_features
--fc_count_type --gtf_count_type
--fc_group_features_type --gtf_group_features_type
--skip_featurecounts -

@drpatelh drpatelh marked this pull request as draft December 9, 2020 17:37
@drpatelh drpatelh marked this pull request as ready for review December 11, 2020 12:17
conf/modules.config Show resolved Hide resolved
main.nf Show resolved Hide resolved
modules/local/process/multiqc.nf Show resolved Hide resolved
modules/local/subworkflow/prepare_genome.nf Show resolved Hide resolved
modules/local/subworkflow/prepare_genome.nf Outdated Show resolved Hide resolved
modules/nf-core/software/salmon/index/main.nf Outdated Show resolved Hide resolved
rnaseq.nf Show resolved Hide resolved
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe the checking that NXF 20.10 is used but otherwise good

@drpatelh
Copy link
Member Author

Thanks @apeltzer @grst ! Will bump Nextflow version in another PR because these changes don't require the latest version.

@drpatelh drpatelh merged commit 69d024f into nf-core:dev Dec 11, 2020
@drpatelh drpatelh deleted the salmon branch December 17, 2020 12:18
@harish0201
Copy link

Not an issue, just a doubt

Hi, is there any reason for removing quantification from HiSAT2 alignments?

@drpatelh
Copy link
Member Author

drpatelh commented Jun 1, 2021

Hi @harish0201 . I wrote a brief description for this in the CHANGELOG (see links to papers there too) and a footnote in the main README at the end of this section.

But to summarise, HISAT2 only generates alignments relative to the genome and not the transcriptome so we can't use tools such as salmon quant (yet) for quantification (see Note). The quantification methods used by featureCounts aren't suited for expression level quantification especially when trying to factor in multiple isoforms / pseudogenes etc which is why it was removed as a downstream quantification option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants