-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all modules to use new functions.nf #591
Conversation
drpatelh
commented
Apr 10, 2021
- See Update functions.nf to be more flexible for publishing by meta keys modules#423
- See [PROOF OF PRINCIPLE] Rename publish_by_id to publish_by_meta and add flexibility of taking a list of ids #590
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but, tbh, I didn't go through every detail
BTW, I am not a big fan of the way you indent lines and align |
No worries! Thanks muchly. You will have a chance to look at it all properly on the merge to |
Oops. Sorry. I do things this way because it makes it easier to read the actual code? 😏 |
We'll just need an autoformatter at some point 🤷 |