Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all modules to use new functions.nf #591

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Update all modules to use new functions.nf #591

merged 5 commits into from
Apr 12, 2021

Conversation

drpatelh
Copy link
Member

@github-actions
Copy link

github-actions bot commented Apr 10, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 48b8bd4

+| ✅ 105 tests passed       |+
#| ❔  13 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: environment.yml
  • files_exist - File not found: Dockerfile
  • nextflow_config - Config variable not found: process.container
  • readme - README did not have a Nextflow minimum version badge.
  • schema_params - Schema param config_profile_name not found from nextflow config

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.3
  • Run at 2021-04-10 20:25:53

@drpatelh drpatelh mentioned this pull request Apr 10, 2021
Closed
10 tasks
@drpatelh drpatelh requested review from apeltzer and grst April 12, 2021 08:05
grst
grst approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but, tbh, I didn't go through every detail

@grst
Copy link
Member

grst commented Apr 12, 2021

BTW, I am not a big fan of the way you indent lines and align = and //. It creates massive diffs where most lines are irrelevant and makes it really hard to review.

@drpatelh
Copy link
Member Author

No worries! Thanks muchly. You will have a chance to look at it all properly on the merge to master 😅

@drpatelh drpatelh merged commit 08894ac into nf-core:dev Apr 12, 2021
@drpatelh
Copy link
Member Author

drpatelh commented Apr 12, 2021 •
edited
Loading

BTW, I am not a big fan of the way you indent lines and align = and //. It creates massive diffs where most lines are irrelevant and makes it really hard to review.

Oops. Sorry. I do things this way because it makes it easier to read the actual code? 😏

@grst
Copy link
Member

grst commented Apr 12, 2021

We'll just need an autoformatter at some point 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

@apeltzer apeltzer Awaiting requested review from apeltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drpatelh @grst