Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejig prepare_genome.nf subworkflow #959

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Rejig prepare_genome.nf subworkflow #959

merged 3 commits into from
Mar 15, 2023

Conversation

drpatelh
Copy link
Member

  • Move all params out of the subworkflow
  • Initialise as value channels where appropriate
  • Bump pipeline version to 3.11.0

maxulysse
maxulysse reviewed Mar 15, 2023
View reviewed changes
subworkflows/local/prepare_genome.nf
ch_versions = ch_versions.mix(GUNZIP_FASTA.out.versions)
} else {
ch_fasta = file(params.fasta)
ch_fasta = Channel.value(file(fasta))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

maxulysse
maxulysse approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b10efc8

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.11.0'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-15 10:54:51

@drpatelh drpatelh merged commit 4656b56 into nf-core:dev Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drpatelh @maxulysse