Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dsl2 updates #33

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Dsl2 updates #33

merged 3 commits into from
Mar 30, 2022

Conversation

praveenraj2018
Copy link
Contributor

  • Minor updates in local modules to compliance with DSL2 format (removed functions.nf and updated module files)
  • Used nf-core gatk4/haplotypecaller instead of a local version
  • Updated local modules to use latest code (ref. rnaseq)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

nf-core lint overall result: Passed ✅

Posted for pipeline commit 799b058

+| ✅ 147 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-03-30 12:57:05

maxulysse
maxulysse approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxulysse maxulysse merged commit 8e01cd9 into nf-core:dev Mar 30, 2022
@praveenraj2018 praveenraj2018 deleted the dsl2_updates branch March 30, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@praveenraj2018 @maxulysse