Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix download cache script + further improvements #141

Merged
merged 19 commits into from
Mar 4, 2020
Merged

fix download cache script + further improvements #141

merged 19 commits into from
Mar 4, 2020

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Mar 4, 2020 •
edited

nf-core/sarek pull request

  • Fix download_cache.nf script (close Fix VEP CI tests #137)
  • Update snpeff and vep database to latest versions
  • Add container for WBcel235
  • Try CI tests for annotation with WBcel235

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Mar 4, 2020
@maxulysse maxulysse added the enhancement New feature or request label Mar 4, 2020
@maxulysse maxulysse added this to Existing pipelines in hackathon-crick-2020 Mar 4, 2020
@maxulysse maxulysse marked this pull request as ready for review March 4, 2020 16:18
@maxulysse maxulysse requested a review from a team March 4, 2020 16:31
ggabernet
ggabernet approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@maxulysse maxulysse merged commit dd2a0ac into nf-core:dev Mar 4, 2020
@maxulysse maxulysse deleted the More2.6Preparation branch March 4, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees

@maxulysse maxulysse

Labels
enhancement New feature or request
Projects
No open projects
hackathon-crick-2020
Existing pipelines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxulysse @ggabernet