Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #135: mutect2 fails with --no_intervals option #146

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Fix issue #135: mutect2 fails with --no_intervals option #146

merged 6 commits into from
Mar 6, 2020

Conversation

lconde-ucl
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This pull request fixes errors in the HaplotypeCaller, GenotypeGVCFs, FreeBayes, Mutect2 and PileupSummariesForMutect2 processes when the pipeline is run with the '--no_intervals" option (it deletes the "-L no_intervals.bed" argument that was causing the problem). It also fixes a bug in the mpileupOut channel (it was generating all possible T-N combinations, similar to the issue Ascat computes all possible N-T combinations #136 in alleleCountOutput)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

main.nf Outdated Show resolved Hide resolved
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@maxulysse
Copy link
Member

@maxulysse maxulysse added enhancement New feature or request and removed work in progress labels Mar 6, 2020
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse merged commit b27014f into nf-core:dev Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants