Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Cloud Storage objects are immutable on GCP #1494

Merged
merged 11 commits into from
May 3, 2024
Merged

Fix: Cloud Storage objects are immutable on GCP #1494

merged 11 commits into from
May 3, 2024

Conversation

maxulysse
Copy link
Member

Most likely culprit is the sort: false in the collectFile()

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test tests/ --verbose --profile +docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5ab5292

+| ✅ 181 tests passed       |+
#| ❔  14 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowSarek.groovy
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-05-03 13:31:20

@maxulysse maxulysse changed the title Fix Cloud Storage objects are immutable Fix: Cloud Storage objects are immutable on GCP + multiple doi handling May 2, 2024
@asp8200
Copy link
Contributor

asp8200 commented May 2, 2024 •
edited
Loading

I guess this should fix this, right?

Has the proposed solution been tested on GCP?

@maxulysse maxulysse mentioned this pull request May 2, 2024
Merged
4 tasks
FriederikeHanssen
FriederikeHanssen previously approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but I think we should get Esha's ok here.

@maxulysse
Copy link
Member Author

maxulysse commented May 2, 2024 •
edited
Loading

cf nf-core/tools#2947

@maxulysse
Copy link
Member Author

sorry for fixing two issues in 1 PR, but I encountered the second issue while fixing the first one

@maxulysse
Copy link
Member Author

splitting the DOI thingy in another PR as it's becoming to be a bigger part of the PR

@maxulysse maxulysse mentioned this pull request May 2, 2024
Merged
11 tasks
@maxulysse maxulysse changed the title Fix: Cloud Storage objects are immutable on GCP + multiple doi handling Fix: Cloud Storage objects are immutable on GCP May 2, 2024
@maxulysse maxulysse merged commit 67914f8 into nf-core:dev May 3, 2024
20 checks passed
@FriederikeHanssen FriederikeHanssen mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxulysse @asp8200 @FriederikeHanssen @SPPearce