Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code polish #152

Merged
merged 12 commits into from
Mar 12, 2020
Merged

Code polish #152

merged 12 commits into from
Mar 12, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added this to the 3.0 milestone Mar 10, 2020
@maxulysse maxulysse requested review from a team and ggabernet March 11, 2020 15:49
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of typos 👍

docs/annotation.md Outdated Show resolved Hide resolved
docs/annotation.md Outdated Show resolved Hide resolved
maxulysse and others added 3 commits March 12, 2020 09:32
Co-Authored-By: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-Authored-By: Gisela Gabernet <gisela.gabernet@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit e4cb662 into nf-core:dev Mar 12, 2020
@maxulysse maxulysse deleted the CodePolish branch March 12, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants