Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS megatest GHA #154

Merged
merged 14 commits into from
Mar 12, 2020
Merged

Add AWS megatest GHA #154

merged 14 commits into from
Mar 12, 2020

Conversation

FriederikeHanssen
Copy link
Contributor

This adds the GHA for aws megatests. It was tested here https://github.com/ggabernet/nf-core-sarek/pull/3
Since the access tokens are not widely shared, I can not run a complete test on my account. However, if we set them up for this repo it should work.

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@FriederikeHanssen FriederikeHanssen changed the title Aws megatests2 Add Aws megatest GHA Mar 11, 2020
@FriederikeHanssen FriederikeHanssen changed the title Add Aws megatest GHA Add AWS megatest GHA Mar 11, 2020
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Amazingly Good To Me

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aws test workflow is called awstest.yml. Do you think it would be possible to just add your edits to that one?

@FriederikeHanssen
Copy link
Contributor Author

The aws test workflow is called awstest.yml. Do you think it would be possible to just add your edits to that one?

Yes of course. Dev branch of my fork wasn't up-to-date, so I oversaw the already existing file. It is done

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions, that will directly add -with-tower as well :)

.github/workflows/awstest.yml Outdated Show resolved Hide resolved
.github/workflows/awstest.yml Outdated Show resolved Hide resolved
@ggabernet ggabernet merged commit ff5a256 into nf-core:dev Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants