Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on the minimal settings #197

Merged
merged 11 commits into from
Apr 29, 2020
Merged

Updates on the minimal settings #197

merged 11 commits into from
Apr 29, 2020

Conversation

maxulysse
Copy link
Member

This one should be the last one on this series from me.
I also included some minor refactoring (sorry).

  • Add a new step: prepare_recalibration

We're actually already saving the BAM and index files for the next step, but as recalibration can only happen with some know variants, there was actually no plan to restart from the calculation of these recalibration tables.
It is now possible.
The idea is to allow people to do preprocessing up until the preparation of the recalibration tables, and follow by some variant calling to allow a creation of know variants resource which can later be used to calculate and do the recalibration and then do some proper variant calling.
cf: https://gatkforums.broadinstitute.org/gatk/discussion/1247/what-should-i-use-as-known-variants-sites-for-running-tool-x

  • fix --step recalibrate which had some issues.
  • fix typo for output directory DuplicateMarked should have been DuplicatesMarked

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse
Copy link
Member Author

Just missing some docs

@maxulysse maxulysse requested review from mahesh-panchal and a team April 28, 2020 14:41
@maxulysse maxulysse self-assigned this Apr 28, 2020
@maxulysse maxulysse added bugfix enhancement New feature or request labels Apr 28, 2020
@maxulysse maxulysse added this to the 2.6 milestone Apr 28, 2020
@maxulysse maxulysse marked this pull request as ready for review April 29, 2020 08:49
@maxulysse maxulysse merged commit 9ae9ce5 into nf-core:dev Apr 29, 2020
@maxulysse maxulysse deleted the Bee branch April 29, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants