-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sarek to 3.0dev #333
Bump sarek to 3.0dev #333
Conversation
… MaxUlysse-2.7
@@ -9,7 +9,7 @@ COPY environment.yml / | |||
RUN conda env create -f /environment.yml && conda clean -a | |||
|
|||
# Add conda installation dir to PATH (instead of doing 'conda activate') | |||
ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-2.7dev/bin:$PATH | |||
ENV PATH /opt/conda/envs/nf-core-sarek-snpeff-dev/bin:$PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not snpeff-3.0dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the question of whether it should be labeled dev or 3.0dev everywhere. I don't have a preference either way
Merged before reading comments 🤦 We can always fix that later... |
Ah no worries. It's a tiny thing about consistency. won't change anything in whether it runs or not. |
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).