Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cellranger to multiqc report #244

Merged
merged 6 commits into from Aug 16, 2023
Merged

Add cellranger to multiqc report #244

merged 6 commits into from Aug 16, 2023

Conversation

grst
Copy link
Member

@grst grst commented Jun 29, 2023 •
edited

Since MultiQC v1.15, there's a cellranger module.
This PR activates this functionality for the cellranger branch of the pipeline.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Partly addresses #80

@github-actions
Copy link

github-actions bot commented Jun 29, 2023 •
edited

nf-core lint overall result: Passed ✅

Posted for pipeline commit 8b5707b

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-07 12:10:12

@grst grst requested a review from fmalmeida August 7, 2023 12:10
SPPearce
SPPearce approved these changes Aug 16, 2023
View reviewed changes
Copy link

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor question about what the map is doing, but otherwise all fine.

workflows/scrnaseq.nf
@@ -193,6 +194,9 @@ workflow SCRNASEQ {
ch_versions = ch_versions.mix(CELLRANGER_ALIGN.out.ch_versions)
ch_mtx_matrices = ch_mtx_matrices.mix(CELLRANGER_ALIGN.out.cellranger_out)
ch_star_index = CELLRANGER_ALIGN.out.star_index
ch_multiqc_cellranger = CELLRANGER_ALIGN.out.cellranger_out.map{
meta, outs -> outs.findAll{ it -> it.name == "web_summary.html"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this part necessary? Is this something that could be changed in the CELLRANGER_ALIGN module to make it play nicely with multiqc out of the box?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly to make MultiQC more efficient, because it only gets the files it needs (the full cellranger output dir contains a lot of files)

@grst grst merged commit 03bf3bf into nf-core:dev Aug 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@fmalmeida fmalmeida Awaiting requested review from fmalmeida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grst @SPPearce