New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kallistobustools #56
Conversation
Further additions:
The lint test is failing because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, I only had a couple of comments, and anyways the "valid" review will be the one to dev
or master
@@ -56,6 +49,17 @@ | |||
"default": "alevin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This param should probably also be an enumeration enum
, so that it can validate that the options are valid, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, still need to have another look over the Schema :)
Thanks a lot for the review @ggabernet ! :) |
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
This PR adds a first, working version of the
kb
orkallistobustools
pipeline.These steps are currently implemented:
The MultiQC output is a bit sad though, as there doesn't exist a module for
kb
.